Fix NDEBUG build after https://reviews.llvm.org/D93005.

[mehdi_amini]

Feel free to push build fixes without going through review: getting the build green is the priority :)

[rriddle]

Feel free to just submit this stuff directly in the future BTW.

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

327

Could we just change this to terminator->successor_begin(), terminator->successor_end() and drop the unused variable?

[csigg]

In D93480#2461166, @mehdi_amini wrote:

Feel free to push build fixes without going through review: getting the build green is the priority :)

I was just trying to change as little as possible from my normal workflow when submitting a fix without review or proper testing. Git and me aren't long-time friends.

[mehdi_amini]

No worry, thanks for the quick fix!

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

 /// of its predecessor.
 static Value getPHISourceValue(Block *current, Block *pred,
                                unsigned numArguments, unsigned index) {
   Operation &terminator = *pred->getTerminator();
   if (isa<LLVM::BrOp>(terminator))
     return terminator.getOperand(index);
 
   SuccessorRange successors = terminator.getSuccessors();
   assert(std::adjacent_find(successors.begin(), successors.end()) ==
              successors.end() &&
          "successors with arguments in LLVM branches must be different blocks");
+  (void)successors;
 
   // For instructions that branch based on a condition value, we need to take
   // the operands for the branch that was taken.
   if (auto condBranchOp = dyn_cast<LLVM::CondBrOp>(terminator)) {
     // For conditional branches, we take the operands from either the "true" or
     // the "false" branch.
     return condBranchOp.getSuccessor(0) == current
                ? condBranchOp.trueDestOperands()[index]