This is an archive of the discontinued LLVM Phabricator instance.

Improve the verifier diagnostic on dominance error
ClosedPublic

Authored by mehdi_amini on Dec 15 2020, 8:19 PM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 15 2020, 8:19 PM
mehdi_amini requested review of this revision.Dec 15 2020, 8:19 PM
rriddle added inline comments.Dec 15 2020, 9:32 PM
mlir/lib/IR/Verifier.cpp
312

Can you create a helper function for this?

Extract into a helper

rriddle added inline comments.Dec 16 2020, 12:49 PM
mlir/lib/IR/Verifier.cpp
250

This function should be marked static. Only classes should go in anonymous namespaces.

rriddle accepted this revision.Dec 16 2020, 12:53 PM

Nice!

mlir/lib/IR/Verifier.cpp
248

nit: Use /// here for the comment.

288

nit: Add a space before the (.

This revision is now accepted and ready to land.Dec 16 2020, 12:53 PM
mehdi_amini marked 3 inline comments as done.Dec 16 2020, 2:03 PM
This revision was landed with ongoing or failed builds.Dec 16 2020, 2:06 PM
This revision was automatically updated to reflect the committed changes.

This is awesome, thank you!