Page MenuHomePhabricator

[OpenMP][NFC] Use CMake Variables
ClosedPublic

Authored by atmnpatel on Dec 15 2020, 3:21 AM.

Details

Summary

This patchs adds the use of CMake variables to add subdirectories and
include directories. In addition, it renames CMake variable to a more
meaningful name that I intend to also define in its parent scope in a
later patch. Both of these variables will be used to have a clean CMake
for the upcoming remote offloading plugin.

Diff Detail

Event Timeline

atmnpatel created this revision.Dec 15 2020, 3:21 AM
atmnpatel requested review of this revision.Dec 15 2020, 3:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2020, 3:21 AM
JonChesterfield accepted this revision.Dec 15 2020, 4:29 AM
JonChesterfield added a subscriber: JonChesterfield.

LGTM. Like the explicit location of source files. Variables are namespaced with the same prefix as others in the file.

This revision is now accepted and ready to land.Dec 15 2020, 4:29 AM
atmnpatel updated this revision to Diff 312301.Dec 16 2020, 2:06 PM

Updated commit message, sanity ping for pre-merge buildbot.

This revision was landed with ongoing or failed builds.Dec 16 2020, 4:05 PM
This revision was automatically updated to reflect the committed changes.