Differential D93181

[NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp
ClosedPublic
Actions

Authored by t-tye on Dec 13 2020, 9:26 AM.

Details

Reviewers

kzhuravl
ronlieb

Commits

rG5ad202ce8963: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

t-tye created this revision.Dec 13 2020, 9:26 AM

Herald added subscribers: dexonsmith, tpr, dstuttard, yaxunl. · View Herald TranscriptDec 13 2020, 9:26 AM

t-tye requested review of this revision.Dec 13 2020, 9:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2020, 9:26 AM

Herald added subscribers: cfe-commits, wdng. · View Herald Transcript

lgtm

This revision is now accepted and ready to land.Dec 13 2020, 9:49 AM

Harbormaster completed remote builds in B82187: Diff 311454.Dec 13 2020, 10:06 AM

This revision was landed with ongoing or failed builds.Dec 13 2020, 3:03 PM

Closed by commit rG5ad202ce8963: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp (authored by t-tye). · Explain Why

This revision was automatically updated to reflect the committed changes.

t-tye added a commit: rG5ad202ce8963: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp.

tra added a subscriber: tra.Dec 14 2020, 10:38 AM

tra added inline comments.

clang/lib/Basic/Cuda.cpp
75	These comments are kind of redundant now as they do not convey anything in addition to the macro itself.

Revision Contents
Changeset List

Path

Size

clang/

lib/

Basic/

45 lines

Diff 311471

clang/lib/Basic/Cuda.cpp

Loading...