Page MenuHomePhabricator

[clang-format] Fix handling of ## comments in TextProto
ClosedPublic

Authored by HazardyKnusperkeks on Dec 12 2020, 8:49 AM.

Details

Summary

As @krasimir said in D92257 the old behavior is buggy.

  • Added checks for ##, ###, and ####.
  • Adapted the test.
  • Removed the check for TextProto, which is already in getLineCommentIndentPrefix.

Diff Detail

Event Timeline

HazardyKnusperkeks requested review of this revision.Dec 12 2020, 8:49 AM
HazardyKnusperkeks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2020, 8:49 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MyDeveloperDay accepted this revision.Dec 12 2020, 10:33 AM
This revision is now accepted and ready to land.Dec 12 2020, 10:33 AM
This revision was landed with ongoing or failed builds.Dec 23 2020, 1:08 PM
This revision was automatically updated to reflect the committed changes.