This is an archive of the discontinued LLVM Phabricator instance.

Differential D93112

LNT: Fix large Mann-Whitney U Test.
ClosedPublic

Authored by tnfchris on Dec 11 2020, 5:57 AM.

Details

Reviewers
thopre
kongyi
Summary

The call to mannwhitneyu_large returns a tuple of two results (the U
statistic and the one-sided p value). This causes a crash when running
with Python 3 due to the comparison between a float and a tuple, however
appears to silently fail with Python 2 which is possibly why it was not
caught sooner.

Since we only care about the one-sided p value, just take that directly.

Diff Detail

Event Timeline

tnfchris requested review of this revision.Dec 11 2020, 5:57 AM
tnfchris created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2020, 5:57 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B82028: Diff 311200.Dec 11 2020, 6:00 AM
thopre accepted this revision.Dec 11 2020, 6:32 AM

LGTM

This revision is now accepted and ready to land.Dec 11 2020, 6:32 AM
tnfchris closed this revision.Dec 13 2020, 6:18 AM

Revision Contents

PathSize
lnt/
util/
2 lines

Diff 311200

lnt/util/stats.py

Context not available.
else: else:
try: try:
# MWU in SciPy is one-sided, multiply by 2 to get two-sided. # MWU in SciPy is one-sided, multiply by 2 to get two-sided.
p = mannwhitneyu_large(a, b) * 2 p = mannwhitneyu_large(a, b)[1] * 2
return p >= sigLevel return p >= sigLevel
except ValueError: except ValueError:
return True return True
Context not available.