Page MenuHomePhabricator

[lld-macho] Support -mattr for LTO
AbandonedPublic

Authored by int3 on Dec 8 2020, 10:28 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

There doesn't seem to be an equivalent test for LLD-ELF, so
I've verified our behavior by cribbing a test from
CodeGen/X86/recip-fastmath.ll.

Diff Detail

Event Timeline

int3 created this revision.Dec 8 2020, 10:28 PM
int3 requested review of this revision.Dec 8 2020, 10:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2020, 10:28 PM

Does this make sense to have as part of a single commit with D92912 to have a change to populate the LTO configuration options?

MaskRay added a subscriber: MaskRay.Dec 9 2020, 9:10 AM

I think we should only support -mllvm (so all LLVM middle-end/codegen options can be used, including -mllvm -mcpu=xxx, not -mcpu= (I don't think anyone uses ld.lld -mcpu=)

int3 added a comment.Dec 9 2020, 1:49 PM

Does this make sense to have as part of a single commit with D92912 to have a change to populate the LTO configuration options?

Sure, I can merge them. FWIW, there are a dozen or so other config options that I have yet to add, but I'm doing it incrementally as I figure out how to test each one.

I don't think anyone uses ld.lld -mcpu=

I did this because -mcpu is supported by ld64.

int3 abandoned this revision.Dec 9 2020, 3:12 PM

merging into D92912