diff --git a/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp --- a/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp +++ b/llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp @@ -792,7 +792,8 @@ StringRef InternalSuffix); Instruction *CreateAsanModuleDtor(Module &M); - bool canInstrumentAliasedGlobal(const GlobalAlias &GA) const; + const GlobalVariable *getExcludedAliasedGlobal(const GlobalAlias &GA, + bool Rec = false) const; bool shouldInstrumentGlobal(GlobalVariable *G) const; bool ShouldUseMachOGlobalsSection() const; StringRef getGlobalMetadataSection() const; @@ -1787,20 +1788,39 @@ } } -bool ModuleAddressSanitizer::canInstrumentAliasedGlobal( - const GlobalAlias &GA) const { - // In case this function should be expanded to include rules that do not just - // apply when CompileKernel is true, either guard all existing rules with an - // 'if (CompileKernel) { ... }' or be absolutely sure that all these rules - // should also apply to user space. - assert(CompileKernel && "Only expecting to be called when compiling kernel"); - - // When compiling the kernel, globals that are aliased by symbols prefixed - // by "__" are special and cannot be padded with a redzone. - if (GA.getName().startswith("__")) - return false; +const GlobalVariable * +ModuleAddressSanitizer::getExcludedAliasedGlobal(const GlobalAlias &GA, + bool Rec) const { + if (!Rec) { // Non-recursive case. + // In case this function should be expanded to include rules that do not + // just apply when CompileKernel is true, either guard all existing rules + // with an 'if (CompileKernel) { ... }' or be absolutely sure that all these + // rules should also apply to user space. + assert(CompileKernel && + "Only expecting to be called when compiling kernel"); + + // When compiling the kernel, globals that are aliased by symbols prefixed + // by "__" are special and cannot be padded with a redzone. + if (!GA.getName().startswith("__")) + return nullptr; + } + + if (const auto *GV = dyn_cast(GA.getAliasee())) { + // Find GlobalVariable from aliasee. + return GV; + } else if (const auto *CE = dyn_cast(GA.getAliasee())) { + // Pointer expression into GlobalVariable; find it from one of the operands. + for (const Use &U : CE->operands()) { + if (const auto *GV = dyn_cast(U)) + return GV; + } + } else if (const auto *GAA = dyn_cast(GA.getAliasee())) { + // Recursive GlobalAlias + return getExcludedAliasedGlobal(*GAA, true); + } - return true; + // Not a GlobalVariable alias, ignore. + return nullptr; } bool ModuleAddressSanitizer::shouldInstrumentGlobal(GlobalVariable *G) const { @@ -2252,14 +2272,12 @@ *CtorComdat = false; // Build set of globals that are aliased by some GA, where - // canInstrumentAliasedGlobal(GA) returns false. + // getExcludedAliasedGlobal(GA) returns the relevant GlobalVariable. SmallPtrSet AliasedGlobalExclusions; if (CompileKernel) { for (auto &GA : M.aliases()) { - if (const auto *GV = dyn_cast(GA.getAliasee())) { - if (!canInstrumentAliasedGlobal(GA)) - AliasedGlobalExclusions.insert(GV); - } + if (const GlobalVariable *GV = getExcludedAliasedGlobal(GA)) + AliasedGlobalExclusions.insert(GV); } }