Page MenuHomePhabricator

Switch to std::is_trivially_move_constructible and std::is_trivially_copy_constructible
ClosedPublic

Authored by MaskRay on Dec 2 2020, 11:00 PM.

Details

Summary

GCC<5 did not support std::is_trivially_{copy,move}_constructible. Now LLVM builds require 5.1
we can migrate to std:: versions.

Diff Detail

Event Timeline

MaskRay created this revision.Dec 2 2020, 11:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 11:00 PM
MaskRay requested review of this revision.Dec 2 2020, 11:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 3 2020, 9:15 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a subscriber: mehdi_amini.EditedDec 3 2020, 10:43 AM

Can you add the motivation/context in your commit message in general?
I can't tell if it is this just "cleanup" and if we upgraded a toolchain recently that makes these not needed anymore?

MaskRay edited the summary of this revision. (Show Details)Dec 3 2020, 10:45 AM
MaskRay edited the summary of this revision. (Show Details)
miyuki added a subscriber: miyuki.Dec 3 2020, 11:44 AM

Hi @MaskRay, this commit broke our builds which use GCC 7.3. I've posted some comments in D92591, but have just realized that it probably was not the right place. Could you please fix the breakage?