This is an archive of the discontinued LLVM Phabricator instance.

Differential D92519

[tsan] Use REAL macro when calling intercepted function
AbandonedPublic

Authored by tstellar on Dec 2 2020, 3:56 PM.

Details

Reviewers
vitalybuka

Diff Detail

Event Timeline

tstellar created this revision.Dec 2 2020, 3:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 3:56 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
tstellar requested review of this revision.Dec 2 2020, 3:56 PM
tstellar added a child revision: D92521: [tsan] Fix build failure with _FORTIFY_SOURCE.Dec 2 2020, 4:01 PM
Harbormaster completed remote builds in B80874: Diff 309085.Dec 2 2020, 5:04 PM
dvyukov edited reviewers, added: vitalybuka; removed: dvyukov.Dec 3 2020, 1:34 AM
dvyukov added a subscriber: dvyukov.
vitalybuka added a comment.Dec 3 2020, 5:33 PM

It intentionally calls interceptor which will call sigaction_impl where all works is done.

vitalybuka requested changes to this revision.Feb 17 2021, 1:43 PM
This revision now requires changes to proceed.Feb 17 2021, 1:43 PM
tstellar abandoned this revision.Nov 1 2021, 5:06 PM

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
rtl/
2 lines

Diff 309085

compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp

//===-- tsan_interceptors_posix.cpp ---------------------------------------===// //===-- tsan_interceptors_posix.cpp ---------------------------------------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 2,438 Lines • ▼ Show 20 Lines
static __sanitizer_sighandler_ptr signal_impl(int sig, static __sanitizer_sighandler_ptr signal_impl(int sig,
__sanitizer_sighandler_ptr h) { __sanitizer_sighandler_ptr h) {
__sanitizer_sigaction act; __sanitizer_sigaction act;
act.handler = h; act.handler = h;
internal_memset(&act.sa_mask, -1, sizeof(act.sa_mask)); internal_memset(&act.sa_mask, -1, sizeof(act.sa_mask));
act.sa_flags = 0; act.sa_flags = 0;
__sanitizer_sigaction old; __sanitizer_sigaction old;
int res = sigaction_symname(sig, &act, &old); int res = REAL(sigaction_symname)(sig, &act, &old);
if (res) return (__sanitizer_sighandler_ptr)sig_err; if (res) return (__sanitizer_sighandler_ptr)sig_err;
return old.handler; return old.handler;
} }
#define TSAN_SYSCALL() \ #define TSAN_SYSCALL() \
ThreadState *thr = cur_thread(); \ ThreadState *thr = cur_thread(); \
if (thr->ignore_interceptors) \ if (thr->ignore_interceptors) \
return; \ return; \
▲ Show 20 Lines • Show All 439 Lines • Show Last 20 Lines