Page MenuHomePhabricator

[lldb] set created function decl to public access in TypeSystemClang
AbandonedPublic

Authored by zequanwu on Dec 2 2020, 2:18 PM.

Details

Reviewers
teemperor
shafik
Summary

Test case stack_unwinding01.cpp crashed in Debug build of lldb on Windows due to access specifier not set for function decl.

Diff Detail

Event Timeline

zequanwu created this revision.Dec 2 2020, 2:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 2:18 PM
zequanwu requested review of this revision.Dec 2 2020, 2:18 PM
teemperor requested changes to this revision.Dec 2 2020, 2:25 PM

D85993 was trying to do the same thing and contains some explanation why I think this isn't a good solution. TL;DR is that functions in a record should call TypeSystemClang::AddMethodToCXXRecordType instead. Moving the isRecord check you add here to the PDB parser code and then calling AddMethodToCXXRecordType depending on whether the check is true/false is one way to fix this properly.

This revision now requires changes to proceed.Dec 2 2020, 2:25 PM
zequanwu abandoned this revision.Dec 9 2020, 4:52 PM

Adrian said he will work on this, so I abandoned this.