Page MenuHomePhabricator

[lld-macho][nfc] Move some methods from InputFile to ObjFile
ClosedPublic

Authored by int3 on Dec 1 2020, 8:15 PM.

Details

Summary

Additionally:

  1. Move the helper functions in InputSection.h below the definition of InputSection, so the important stuff is on top
  2. Remove unnecessary explicit

Diff Detail

Event Timeline

int3 created this revision.Dec 1 2020, 8:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2020, 8:15 PM
int3 requested review of this revision.Dec 1 2020, 8:15 PM
compnerd accepted this revision.Dec 2 2020, 8:48 AM
compnerd added a subscriber: compnerd.

The change itself is fine, though I think that the commit message can be improved. The shuffling of the code should be called out in the summary IMO.

This revision is now accepted and ready to land.Dec 2 2020, 8:48 AM
int3 added a comment.Dec 2 2020, 8:53 AM

Shuffling of which code? The changes to InputSection are mentioned in the summary, and the changes to InputFile are mentioned in the commit title

int3 edited the summary of this revision. (Show Details)Dec 2 2020, 6:48 PM
int3 updated this revision to Diff 309121.Dec 2 2020, 6:48 PM

update

This revision was automatically updated to reflect the committed changes.