Page MenuHomePhabricator

repair cygwin build
ClosedPublic

Authored by vtjnash on Nov 30 2020, 11:14 AM.

Details

Summary

This is needed for cross-compiling LLVM from Cygwin, but it had gotten
deleted in rG2724d9e12960cc1d93eeabbfc9aa1bffffa041cc

Diff Detail

Event Timeline

vtjnash created this revision.Nov 30 2020, 11:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 11:14 AM
vtjnash requested review of this revision.Nov 30 2020, 11:14 AM
vtjnash edited the summary of this revision. (Show Details)
vtjnash added subscribers: Restricted Project, maleadt.
compnerd accepted this revision.Dec 2 2020, 8:52 AM

That really is unfortunate. LLVM generally does a pretty good job of sticking to standard C++. The symbols you claim are missing aren't C++ symbols but rather C symbols. I suppose that this doesn't hurt the other targets.

This revision is now accepted and ready to land.Dec 2 2020, 8:52 AM

I think with the move to newer C++ standards, some of the missing functionality in C could be replicated (or use the _WIN32 code paths for __CYGWIN__ in more places). I tried that for a bit, but it was pieces like struct sigaction, realpath, and getsid missing, which are very platform-specific.

Thanks.

This revision was automatically updated to reflect the committed changes.