This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Add symbol origin for remote index
ClosedPublic

Authored by kbobyrev on Nov 26 2020, 6:51 PM.

Details

Summary

Makes it easier to diagnose remote index issues with --debug-origins flag.

Diff Detail

Event Timeline

kbobyrev created this revision.Nov 26 2020, 6:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2020, 6:51 PM
kbobyrev requested review of this revision.Nov 26 2020, 6:51 PM
sammccall accepted this revision.Nov 27 2020, 3:00 AM
sammccall added inline comments.
clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp
164–165

I think we should just overwrite rather than OR.
In practice the remote side is always going to be Static, but we don't really want to conflate this with the client-side static index.

Actually, do you think we should set this on the *outgoing* side (i.e. have the proto say remote)?

This revision is now accepted and ready to land.Nov 27 2020, 3:00 AM
kbobyrev updated this revision to Diff 308016.Nov 27 2020, 4:12 AM

Don't assign additional Remote Origin: overwrite it.

This revision was landed with ongoing or failed builds.Nov 28 2020, 6:41 AM
This revision was automatically updated to reflect the committed changes.