This is an archive of the discontinued LLVM Phabricator instance.

[ASTImporter] Import the default argument of NonTypeTemplateParmDecl
ClosedPublic

Authored by teemperor on Nov 25 2020, 8:07 AM.

Details

Summary

The test case isn't using the AST matchers for all checks as there doesn't seem to be support for
matching NonTypeTemplateParmDecl default arguments. Otherwise this is simply importing the
default arguments.

Diff Detail

Event Timeline

teemperor created this revision.Nov 25 2020, 8:07 AM
teemperor requested review of this revision.Nov 25 2020, 8:07 AM
martong accepted this revision.Nov 25 2020, 9:44 AM

This looks good as well, thanks!

clang/lib/AST/ASTImporter.cpp
5231–5245

Good catch!

This revision is now accepted and ready to land.Nov 25 2020, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 27 2020, 2:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
shafik added inline comments.Nov 30 2020, 2:13 PM
clang/unittests/AST/ASTImporterTest.cpp
965

Might make sense to test multiple default arguments and types.