This is an archive of the discontinued LLVM Phabricator instance.

Differential D91377

[flang] Recognize END FILE as ENDFILE in free form source
ClosedPublic

Authored by klausler on Nov 12 2020, 12:03 PM.

Details

Reviewers
PeteSteinfeld
Commits
rG6c516cda3974: [flang] Recognize END FILE as ENDFILE in free form source
Summary

The ENDFILE statement may be spelled as two words.

Diff Detail

Event Timeline

klausler created this revision.Nov 12 2020, 12:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2020, 12:03 PM
Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript
klausler requested review of this revision.Nov 12 2020, 12:03 PM
Harbormaster completed remote builds in B78668: Diff 304929.Nov 12 2020, 12:39 PM
PeteSteinfeld accepted this revision.Nov 12 2020, 12:43 PM

All builds, tests, and looks good.

This revision is now accepted and ready to land.Nov 12 2020, 12:43 PM
Closed by commit rG6c516cda3974: [flang] Recognize END FILE as ENDFILE in free form source (authored by klausler). · Explain WhyNov 12 2020, 12:53 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG6c516cda3974: [flang] Recognize END FILE as ENDFILE in free form source.

Revision Contents

PathSize
flang/
lib/
Parser/
2 lines
test/
Semantics/
3 lines

Diff 304943

flang/lib/Parser/io-parsers.cpp

Show First 20 Lines • Show All 308 Lines • ▼ Show 20 Lines
// R1224 backspace-stmt -> // R1224 backspace-stmt ->
// BACKSPACE file-unit-number | BACKSPACE ( position-spec-list ) // BACKSPACE file-unit-number | BACKSPACE ( position-spec-list )
TYPE_CONTEXT_PARSER("BACKSPACE statement"_en_US, TYPE_CONTEXT_PARSER("BACKSPACE statement"_en_US,
construct<BackspaceStmt>("BACKSPACE" >> positionOrFlushSpecList)) construct<BackspaceStmt>("BACKSPACE" >> positionOrFlushSpecList))
// R1225 endfile-stmt -> // R1225 endfile-stmt ->
// ENDFILE file-unit-number | ENDFILE ( position-spec-list ) // ENDFILE file-unit-number | ENDFILE ( position-spec-list )
TYPE_CONTEXT_PARSER("ENDFILE statement"_en_US, TYPE_CONTEXT_PARSER("ENDFILE statement"_en_US,
construct<EndfileStmt>("ENDFILE" >> positionOrFlushSpecList)) construct<EndfileStmt>("END FILE" >> positionOrFlushSpecList))
// R1226 rewind-stmt -> REWIND file-unit-number | REWIND ( position-spec-list ) // R1226 rewind-stmt -> REWIND file-unit-number | REWIND ( position-spec-list )
TYPE_CONTEXT_PARSER("REWIND statement"_en_US, TYPE_CONTEXT_PARSER("REWIND statement"_en_US,
construct<RewindStmt>("REWIND" >> positionOrFlushSpecList)) construct<RewindStmt>("REWIND" >> positionOrFlushSpecList))
// R1227 position-spec -> // R1227 position-spec ->
// [UNIT =] file-unit-number | IOMSG = iomsg-variable | // [UNIT =] file-unit-number | IOMSG = iomsg-variable |
// IOSTAT = scalar-int-variable | ERR = label // IOSTAT = scalar-int-variable | ERR = label
▲ Show 20 Lines • Show All 355 Lines • Show Last 20 Lines

flang/test/Semantics/call10.f90

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Lines pure subroutine s12
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
print *, 'hi' ! C1597 print *, 'hi' ! C1597
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
open(1, file='launch-codes') ! C1597 open(1, file='launch-codes') ! C1597
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
close(1) ! C1597 close(1) ! C1597
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
backspace(1) ! C1597 backspace(1) ! C1597
!Also checks parsing of variant END FILE spelling
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
endfile(1) ! C1597 end file(1) ! C1597
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
rewind(1) ! C1597 rewind(1) ! C1597
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
flush(1) ! C1597 flush(1) ! C1597
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
wait(1) ! C1597 wait(1) ! C1597
!ERROR: External I/O is not allowed in a pure subprogram !ERROR: External I/O is not allowed in a pure subprogram
inquire(1, name=buff) ! C1597 inquire(1, name=buff) ! C1597
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines