Page MenuHomePhabricator

[mlir][bufferize] Fix buffer promotion to stack for index types
ClosedPublic

Authored by herhut on Nov 12 2020, 8:10 AM.

Details

Summary

The index type does not have a bitsize and hence the size of corresponding allocations cannot be computed. Instead, the promotion pass now has an explicit option to specify the size of index.

Diff Detail

Event Timeline

herhut created this revision.Nov 12 2020, 8:10 AM
herhut requested review of this revision.Nov 12 2020, 8:10 AM
dfki-mako accepted this revision.Nov 12 2020, 2:33 PM
This revision is now accepted and ready to land.Nov 12 2020, 2:33 PM
dfki-jugr accepted this revision.Nov 13 2020, 12:29 AM
dfki-jugr added inline comments.
mlir/lib/Transforms/BufferOptimizations.cpp
40

Just a question about the naming: bitWidth or bitwidth? It seems that there is no consistency in the naming in the whole project. Wouldn't it make sense to have only one name?