Page MenuHomePhabricator

[libcxx] Add missing _LIBCPP_FUNC_VIS on a couple win32 locale functions
ClosedPublic

Authored by mstorsjo on Thu, Nov 12, 1:00 AM.

Details

Summary

These functions are called directly from the public installed headers, and thus need to be exported in DLL builds, just like some other functions in the same header (e.g. snprintf_l).

This fixes e.g. test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_float.pass.cpp in mingw configurations.

Diff Detail

Event Timeline

mstorsjo created this revision.Thu, Nov 12, 1:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Nov 12, 1:00 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
mstorsjo requested review of this revision.Thu, Nov 12, 1:00 AM
ldionne accepted this revision.Tue, Nov 17, 2:24 PM
This revision is now accepted and ready to land.Tue, Nov 17, 2:24 PM