This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [Process/Utility] Fix DR offsets for FreeBSD
ClosedPublic

Authored by mgorny on Nov 11 2020, 6:03 AM.

Details

Summary

Fix Debug Register offsets to be specified relatively to UserArea
on FreeBSD/amd64 and FreeBSD/i386, and add them to UserArea on i386.
This fixes overlapping GPRs and DRs in gdb-remote protocol, making it
impossible to correctly get and set debug registers from the LLDB
client.

Diff Detail

Event Timeline

mgorny created this revision.Nov 11 2020, 6:03 AM
mgorny requested review of this revision.Nov 11 2020, 6:03 AM
krytarowski accepted this revision.Nov 11 2020, 6:10 AM
This revision is now accepted and ready to land.Nov 11 2020, 6:10 AM
labath accepted this revision.Nov 12 2020, 1:30 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2020, 5:09 AM