This is an archive of the discontinued LLVM Phabricator instance.

[Matrix] Update mangling to use paramterized vendor ext type syntax.
ClosedPublic

Authored by fhahn on Nov 11 2020, 5:56 AM.

Details

Summary

The Itanium CXX ABI grammer has been extended to support parameterized
vendor extended types [1].

This patch updates Clang's mangling for matrix types to use the new
extension.

[1] https://github.com/itanium-cxx-abi/cxx-abi/commit/b359d28971bdb961dd9b61bd0ef8c884452b4740

Diff Detail

Event Timeline

fhahn created this revision.Nov 11 2020, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2020, 5:56 AM
Herald added a subscriber: tschuett. · View Herald Transcript
fhahn requested review of this revision.Nov 11 2020, 5:56 AM
rjmccall added inline comments.Nov 11 2020, 10:13 AM
clang/lib/AST/ItaniumMangle.cpp
3496–3498

"Mangle matrix types as a vendor extended type:"

3525

Your Is and Es are backwards.

fhahn updated this revision to Diff 304605.Nov 11 2020, 11:37 AM

Update comment and fix I and E order

fhahn marked an inline comment as done.Nov 11 2020, 11:39 AM
fhahn added inline comments.
clang/lib/AST/ItaniumMangle.cpp
3525

Argh, used different orders for comment & code :( Should be fixed now.

This revision is now accepted and ready to land.Nov 11 2020, 11:43 AM
This revision was landed with ongoing or failed builds.Nov 11 2020, 1:39 PM
This revision was automatically updated to reflect the committed changes.