This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove wasm-specific TLS builtins
AbandonedPublic

Authored by sbc100 on Nov 10 2020, 5:56 PM.

Details

Reviewers
tlively
Summary

These builtins don't have any actual users in the real
world. We can add these back later if we find a genuine
use for them.

Diff Detail

Event Timeline

sbc100 created this revision.Nov 10 2020, 5:56 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 10 2020, 5:56 PM
sbc100 requested review of this revision.Nov 10 2020, 5:56 PM
tlively accepted this revision.Nov 10 2020, 6:32 PM

Excellent, thanks. I hope I'm not forgetting any good reason we added these. Emscripten doesn't use them in its pthreads runtime, right?

This revision is now accepted and ready to land.Nov 10 2020, 6:32 PM

I don't think so but I will double check.

I'm in the middle of some TLS rethinking so I'll leave this open for now pending any changes to our TLS ABI.

Nope I was wrong, emscripten does use these.

sbc100 abandoned this revision.Nov 10 2020, 9:36 PM