diff --git a/clang-tools-extra/clangd/refactor/Rename.cpp b/clang-tools-extra/clangd/refactor/Rename.cpp --- a/clang-tools-extra/clangd/refactor/Rename.cpp +++ b/clang-tools-extra/clangd/refactor/Rename.cpp @@ -123,6 +123,7 @@ // name validation. RenameToKeywords, + SameName, }; llvm::Optional renameable(const NamedDecl &RenameDecl, @@ -213,6 +214,8 @@ return "there are multiple symbols at the given location"; case ReasonToReject::RenameToKeywords: return "the chosen name is a keyword"; + case ReasonToReject::SameName: + return "new name should differ from the old name"; } llvm_unreachable("unhandled reason kind"); }; @@ -558,6 +561,8 @@ return makeError(ReasonToReject::AmbiguousSymbol); const auto &RenameDecl = llvm::cast(*(*DeclsUnderCursor.begin())->getCanonicalDecl()); + if (RenameDecl.getName() == RInputs.NewName) + return makeError(ReasonToReject::SameName); auto Invalid = checkName(RenameDecl, RInputs.NewName); if (Invalid) return makeError(*Invalid); diff --git a/clang-tools-extra/clangd/unittests/RenameTests.cpp b/clang-tools-extra/clangd/unittests/RenameTests.cpp --- a/clang-tools-extra/clangd/unittests/RenameTests.cpp +++ b/clang-tools-extra/clangd/unittests/RenameTests.cpp @@ -876,7 +876,7 @@ auto Results = runPrepareRename(Server, FooCCPath, FooCC.point(), /*NewName=*/llvm::None, {/*CrossFile=*/true}); - // verify that for multi-file rename, we only return main-file occurrences. + // Verify that for multi-file rename, we only return main-file occurrences. ASSERT_TRUE(bool(Results)) << Results.takeError(); // We don't know the result is complete in prepareRename (passing a nullptr // index internally), so GlobalChanges should be empty. @@ -884,7 +884,7 @@ EXPECT_THAT(FooCC.ranges(), testing::UnorderedElementsAreArray(Results->LocalChanges)); - // verify name validation. + // Name validation. Results = runPrepareRename(Server, FooCCPath, FooCC.point(), /*NewName=*/std::string("int"), {/*CrossFile=*/true}); @@ -892,7 +892,14 @@ EXPECT_THAT(llvm::toString(Results.takeError()), testing::HasSubstr("keyword")); - // single-file rename on global symbols, we should report an error. + Results = + runPrepareRename(Server, FooCCPath, FooCC.point(), + /*NewName=*/std::string("func"), {/*CrossFile=*/true}); + EXPECT_FALSE(Results); + EXPECT_THAT(llvm::toString(Results.takeError()), + testing::HasSubstr("new name should differ")); + + // Single-file rename on global symbols, we should report an error. Results = runPrepareRename(Server, FooCCPath, FooCC.point(), /*NewName=*/llvm::None, {/*CrossFile=*/false}); EXPECT_FALSE(Results);