This is an archive of the discontinued LLVM Phabricator instance.

[OMPIRBuilder] Start 'Create' methods with lower case. NFC.
ClosedPublic

Authored by Meinersbur on Nov 9 2020, 4:39 PM.

Details

Summary

For consistency with the IRBuilder, OpenMPIRBuilder has method names starting with 'Create'. However, the LLVM coding style has methods names starting with lower case letters, as all other OpenMPIRBuilder already methods do. The clang-tidy configuration used by Phabricator also warns about the naming violation, adding noise to the reviews.

This patch renames all OpenMPIRBuilder::CreateXYZ methods to OpenMPIRBuilder::createXYZ, and updates all in-tree callers.

I tested check-llvm, check-clang, check-mlir and check-flang to ensure that I did not miss a caller.

Diff Detail

Event Timeline

Meinersbur created this revision.Nov 9 2020, 4:39 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Meinersbur requested review of this revision.Nov 9 2020, 4:39 PM
mehdi_amini accepted this revision.Nov 9 2020, 4:44 PM
This revision is now accepted and ready to land.Nov 9 2020, 4:44 PM
Meinersbur updated this revision to Diff 304011.Nov 9 2020, 4:44 PM

Missed reference of CreateXXXX in comments

fghanim accepted this revision.Nov 9 2020, 4:45 PM
fghanim added a subscriber: fghanim.

LGTM

Meinersbur updated this revision to Diff 304013.Nov 9 2020, 4:46 PM

Last update pushed only the change

This revision was landed with ongoing or failed builds.Nov 9 2020, 5:35 PM
This revision was automatically updated to reflect the committed changes.