This is an archive of the discontinued LLVM Phabricator instance.

Allow running back-deployment testing against libc++abi
ClosedPublic

Authored by ldionne on Nov 9 2020, 4:54 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Commits
rG60ba1fefab92: [libc++/abi] Allow running back-deployment testing against libc++abi
Summary

Before this patch, we could only link against the back-deployment libc++abi
dylib. This patch allows linking against the just-built libc++abi, but
running against the back-deployment one -- just like we do for libc++.

Also, add XFAIL markup to flag expected errors.

Diff Detail

Event Timeline

ldionne created this revision.Nov 9 2020, 4:54 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptNov 9 2020, 4:54 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Nov 9 2020, 4:54 AM
ldionne updated this revision to Diff 326462.Feb 25 2021, 11:52 AM

Rebase onto main to trigger the CI and see what's missing to close the loop on this.

ldionne updated this revision to Diff 326718.Feb 26 2021, 9:09 AM

Fix failing tests.

ldionne accepted this revision as: Restricted Project, Restricted Project.Mar 1 2021, 9:14 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2021, 9:14 AM
This revision was automatically updated to reflect the committed changes.