[llvm] Check the debug info line table for basic block sections.

[snehasish]

Summary

Extend the existing basic block sections debug info test to check for the correctness of the generated line table.

[dblaikie]

Looks OK - though you might want to check with -v output or otherwise check the addresses maybe? It might be the llvm-dwarfdump output, even with -v, is a bit hard to test what you may want to test on an object file - validating which line table entries are referring to which sections. If you want to test at that level to ensure the portions of the line table refer to the right bb sections, it might involve enhancing llvm-dwarfdump -v -debug-line output to include the name of the section (& section number, in cases where the name may not be unique (-fno-unique-section-names)) in a similar way to llvm-dwarfdump's output for debug_ranges/loc/etc.

[MaskRay]

llvm/test/DebugInfo/X86/basic-block-sections_1.ll

2

x86_64-* -> x86_64

[snehasish]

Check addresses as well, simplify triple.

[snehasish]

Thanks for the review David. I've added the addresses to the test for now. Extending the verbose output for dwarfdump seems like a good idea, we will look into adding that in the future.

llvm/test/DebugInfo/X86/basic-block-sections_1.ll

 ; RUN: llc -O0 %s -mtriple=x86_64 -filetype=obj -o %t && llvm-dwarfdump -debug-info -v %t | FileCheck --check-prefix=NO-SECTIONS %s
 ; RUN: llc -O0 %s --basic-block-sections=all --unique-basic-block-section-names -mtriple=x86_64 -filetype=obj -o %t && llvm-dwarfdump -debug-info -v %t | FileCheck --check-prefix=BB-SECTIONS %s
 ; RUN: llc -O0 %s --basic-block-sections=all --unique-basic-block-section-names -mtriple=x86_64 -filetype=obj -split-dwarf-file=%t.dwo -o %t && llvm-dwarfdump -debug-info -v %t | FileCheck --check-prefix=BB-SECTIONS %s
 ; RUN: llc -O0 %s --basic-block-sections=all -mtriple=x86_64 -o - | FileCheck --check-prefix=BB-SECTIONS-ASM %s
+; RUN: llc -O0 %s -mtriple=x86_64 -filetype=obj -o %t && llvm-dwarfdump  -debug-line %t | FileCheck --check-prefix=BB-SECTIONS-LINE-TABLE %s
 
 ; From:
-; int foo(int a) {
-;   if (a > 20)
-;     return 2;
-;   else
-;     return 0;
-; }
+; 1  int foo(int a) {
+; 2    if (a > 20)
+; 3      return 2;
+; 4    else
+; 5      return 0;
+; 6  }
 
 ; NO-SECTIONS: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000 ".text")
 ; NO-SECTIONS: DW_AT_high_pc [DW_FORM_data4] ({{.*}})
 ; BB-SECTIONS: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000)
 ; BB-SECTIONS-NEXT: DW_AT_ranges [DW_FORM_sec_offset]
 ; BB-SECTIONS-NEXT: [{{.*}}) ".text._Z3fooi.1"
 ; BB-SECTIONS-NEXT: [{{.*}}) ".text._Z3fooi.2"
 ; BB-SECTIONS-NEXT: [{{.*}}) ".text._Z3fooi.3"

 ; BB-SECTIONS-ASM-NEXT: .quad _Z3fooi.2
 ; BB-SECTIONS-ASM-NEXT: .quad .LBB_END0_{{[0-9]+}}
 ; BB-SECTIONS-ASM-NEXT: .quad _Z3fooi.3
 ; BB-SECTIONS-ASM-NEXT: .quad .LBB_END0_{{[0-9]+}}
 ; BB-SECTIONS-ASM-NEXT: .quad .Lfunc_begin0
 ; BB-SECTIONS-ASM-NEXT: .quad .Lfunc_end0
 ; BB-SECTIONS-ASM-NEXT: .quad 0
 ; BB-SECTIONS-ASM-NEXT: .quad 0
+; BB-SECTIONS-LINE-TABLE:      0x0000000000000000 1 0 1 0 0 is_stmt
+; BB-SECTIONS-LINE-TABLE-NEXT: 0x0000000000000004 2 9 1 0 0 is_stmt prologue_end
+; BB-SECTIONS-LINE-TABLE-NEXT: 0x0000000000000009 2 7 1 0 0
+; BB-SECTIONS-LINE-TABLE-NEXT: 0x000000000000000b 3 5 1 0 0 is_stmt
+; BB-SECTIONS-LINE-TABLE-NEXT: 0x0000000000000015 5 5 1 0 0 is_stmt
+; BB-SECTIONS-LINE-TABLE-NEXT: 0x000000000000001d 6 1 1 0 0 is_stmt
+; BB-SECTIONS-LINE-TABLE-NEXT: 0x0000000000000022 6 1 1 0 0 is_stmt end_sequence
 
 ; Function Attrs: noinline nounwind optnone uwtable
 define dso_local i32 @_Z3fooi(i32 %0) !dbg !7 {
   %2 = alloca i32, align 4
   %3 = alloca i32, align 4
   store i32 %0, i32* %3, align 4
   call void @llvm.dbg.declare(metadata i32* %3, metadata !11, metadata !DIExpression()), !dbg !12
   %4 = load i32, i32* %3, align 4, !dbg !13