This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add parsing tests and semantic check for set directive
ClosedPublic

Authored by clementval on Nov 4 2020, 8:58 AM.

Details

Summary

This patch add some parsing and clause validity tests for the set directive.
It makes use of the possibility introduces in patch D90770 to check the restriction
were one of the default_async, device_num and device_type clauses is required but also
not more than once on the set directive.

Diff Detail

Event Timeline

clementval created this revision.Nov 4 2020, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2020, 8:58 AM
clementval requested review of this revision.Nov 4 2020, 8:58 AM
clementval updated this revision to Diff 302865.

Remove unwanted code

sameeranjoshi accepted this revision.Nov 5 2020, 10:18 AM
sameeranjoshi added inline comments.
flang/test/Semantics/acc-clause-validity.f90
70

nit: - Maybe a couple of tests with combinations of default_async, device_num, device_type.

This revision is now accepted and ready to land.Nov 5 2020, 10:18 AM
clementval updated this revision to Diff 303314.Nov 5 2020, 7:35 PM

Rebase + address review comment

This revision was landed with ongoing or failed builds.Nov 5 2020, 7:59 PM
This revision was automatically updated to reflect the committed changes.