Page MenuHomePhabricator

[VPlan] Use VPDef for VPWidenSelectRecipe.
Needs ReviewPublic

Authored by fhahn on Nov 1 2020, 10:43 AM.

Details

Summary

This patch turns updates VPWidenSelectRecipe to manage the value
it defines using VPDef. The VPValue is used during VPlan
construction and codegeneration instead of the plain IR reference
where possible.

Diff Detail

Unit TestsFailed

TimeTest
360 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

fhahn created this revision.Nov 1 2020, 10:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2020, 10:43 AM
fhahn requested review of this revision.Nov 1 2020, 10:43 AM
fhahn updated this revision to Diff 303234.Thu, Nov 5, 12:58 PM

Updated to keep VPWidenSelectRecipe a VPValue which is then added to its VPDef. This simplifies things a bit.

fhahn updated this revision to Diff 303406.Fri, Nov 6, 4:52 AM

Update after VPDef does not inherit from VPUser directly.

fhahn updated this revision to Diff 306911.Sun, Nov 22, 6:14 AM

Rebase after all dependent patches landed & ping :)