This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
clang/test/AST/
-
test/
-
AST/
1/2
ast-dump-recovery.m

Differential D90140

[clang][RecoveryExpr] Add tests for ObjectiveC.
ClosedPublic

Authored by hokein on Oct 26 2020, 2:54 AM.

Download Raw Diff

Details

Reviewers

Commits

rG2c2dc7c392a3: [clang][RecoveryExpr] Add tests for ObjectiveC.

Summary

to demonstrate it works for some cases.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

hokein created this revision.Oct 26 2020, 2:54 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2020, 2:54 AM

hokein requested review of this revision.Oct 26 2020, 2:54 AM

Harbormaster completed remote builds in B76364: Diff 300610.Oct 26 2020, 3:23 AM

sammccall accepted this revision.Oct 26 2020, 7:33 AM

sammccall added inline comments.

clang/test/AST/ast-dump-recovery.m
9	this contains the resolved selector so go-to-def on `method` will work, right? Really cool :-)

This revision is now accepted and ready to land.Oct 26 2020, 7:33 AM

hokein added inline comments.Oct 27 2020, 1:43 AM

clang/test/AST/ast-dump-recovery.m
9	yes.

This revision was landed with ongoing or failed builds.Oct 27 2020, 1:43 AM

Closed by commit rG2c2dc7c392a3: [clang][RecoveryExpr] Add tests for ObjectiveC. (authored by hokein). · Explain Why

This revision was automatically updated to reflect the committed changes.

hokein added a commit: rG2c2dc7c392a3: [clang][RecoveryExpr] Add tests for ObjectiveC..

Revision Contents

Path

Size

clang/

test/

AST/

ast-dump-recovery.m

18 lines

Diff 300914

clang/test/AST/ast-dump-recovery.m

This file was added.

				// RUN: not %clang_cc1 -triple x86_64-unknown-unknown -frecovery-ast -frecovery-ast-type -ast-dump %s \| FileCheck -strict-whitespace %s

				@interface Foo
				- (void)method:(int)n;
				@end

				void k(Foo *foo) {
				// CHECK: ObjCMessageExpr {{.*}} 'void' contains-errors
				// CHECK-CHECK: \|-ImplicitCastExpr {{.}} 'Foo ' <LValueToRValue>
				sammccallUnsubmitted Not Done Reply Inline Actions this contains the resolved selector so go-to-def on `method` will work, right? Really cool :-) sammccall: this contains the resolved selector so go-to-def on `method` will work, right? Really cool :-)
				hokeinAuthorUnsubmitted Done Reply Inline Actions yes. hokein: yes.
				// CHECK-CHECK: \| `-DeclRefExpr {{.*}} 'foo'
				// CHECK-CHECK: `-RecoveryExpr {{.*}}
				[foo method:undef];

				// CHECK: ImplicitCastExpr {{.*}} '<dependent type>' contains-errors
				// CHECK-NEXT: `-RecoveryExpr {{.*}} '<dependent type>' contains-errors
				// CHECK-NEXT: `-DeclRefExpr {{.*}} 'foo'
				foo.undef;
				}