This is an archive of the discontinued LLVM Phabricator instance.

Add mips64 support in lib/tsan/go/buildgo.sh
ClosedPublic

Authored by mzh on Oct 25 2020, 8:55 PM.

Details

Reviewers
dvyukov
Summary

Enable mips64 support in buildgo.sh.

Diff Detail

Event Timeline

mzh created this revision.Oct 25 2020, 8:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2020, 8:55 PM
Herald added subscribers: Restricted Project, atanasyan, arichardson, sdardis. · View Herald Transcript
mzh requested review of this revision.Oct 25 2020, 8:55 PM
mzh updated this revision to Diff 300580.Oct 25 2020, 11:18 PM

clang-format

dvyukov added inline comments.Oct 26 2020, 12:16 AM
compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
41

Please upload diff with full context (-U999999) next time:
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
It makes it much easier to review. E.g. this block is under #if defined(__mips64) which is not visible in the diff.

compiler-rt/lib/tsan/rtl/tsan_platform.h
516

It seems that the only VM size for this arch is 47 bits, so it should not use TSAN_RUNTIME_VMA. It's slower.

In the functions below execution should go into existing cases like
IsShadowMemImpl<Mapping>(mem);
I think no added code should be needed there.

mzh updated this revision to Diff 300587.Oct 26 2020, 12:34 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 26 2020, 12:34 AM
mzh marked 2 inline comments as done.Oct 26 2020, 12:35 AM

Thanks @dvyukov

All done.

This now looks like a patch for some other change :)

mzh updated this revision to Diff 300588.Oct 26 2020, 12:39 AM
mzh added a comment.Oct 26 2020, 12:41 AM

This now looks like a patch for some other change :)

Sorry! It's my first time with llvm patch submission.
I think it's ok now.

dvyukov accepted this revision.Oct 26 2020, 12:42 AM

Looks good to me.
Do you want me to merge this change?

This revision is now accepted and ready to land.Oct 26 2020, 12:42 AM
mzh added a comment.Oct 26 2020, 1:45 AM

Looks good to me.
Do you want me to merge this change?

Sure, Thanks :)