Page MenuHomePhabricator

[mlir] Failure when const matcher fails, added a test to catch
ClosedPublic

Authored by rsuderman on Oct 16 2020, 1:51 PM.

Diff Detail

Event Timeline

rsuderman created this revision.Oct 16 2020, 1:51 PM
rsuderman requested review of this revision.Oct 16 2020, 1:51 PM
rsuderman retitled this revision from Fixed a failure when const matcher fails, added a test to catch to [mlir] Failure when const matcher fails, added a test to catch.
GMNGeoffrey accepted this revision.Oct 16 2020, 2:14 PM
This revision is now accepted and ready to land.Oct 16 2020, 2:14 PM
jpienaar accepted this revision.Oct 16 2020, 3:01 PM

Woops, I missed this asking for this test. Thanks

Can you provide a more descriptive commit message? I can't understand it (feel free to provide a description on top of the title).

Also you can leave out "added a test to catch", adding a test with a bug fix is implicit :)