This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Spilling using flat scratch
AbandonedPublic

Authored by rampitec on Oct 14 2020, 1:34 PM.

Details

Summary

In theory at this point flat scratch should be functional.

Diff Detail

Event Timeline

rampitec created this revision.Oct 14 2020, 1:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2020, 1:34 PM
rampitec requested review of this revision.Oct 14 2020, 1:34 PM
rampitec planned changes to this revision.Oct 15 2020, 11:00 AM
rampitec added a reviewer: sebastian-ne.

It needs ST addressing mode on GFX10.

A fantastic result that it has passed PSDB on gfx9 with flat scratch enabled. I did not expect it to start working from the first attempt.

A fantastic result that it has passed PSDB on gfx9 with flat scratch enabled. I did not expect it to start working from the first attempt.

Should try with -O0 too

A fantastic result that it has passed PSDB on gfx9 with flat scratch enabled. I did not expect it to start working from the first attempt.

Should try with -O0 too

I do not think it will pass with -O0 without my changes.

rampitec updated this revision to Diff 298707.Oct 16 2020, 12:05 PM

Switched to ST mode on GFX10 is no SOffset is used.

rampitec updated this revision to Diff 299194.Oct 19 2020, 3:28 PM

Rebased to parent.

rampitec abandoned this revision.Oct 21 2020, 3:27 PM

I am integrating it into parent revision.