This is an archive of the discontinued LLVM Phabricator instance.

[flang][windows] Run regression tests under Windows. NFCI.
ClosedPublic

Authored by Meinersbur on Oct 13 2020, 11:58 PM.

Details

Summary

Allow the lit test test suite to run under Windows. This encompasses the following changes:

  • Define lit_tools_dir for flang's test configuration
  • Replace (<command> || true) idiom with not <command>
  • Add REQUIRES: shell on tests that invoke a shell script

Diff Detail

Event Timeline

Meinersbur created this revision.Oct 13 2020, 11:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2020, 11:58 PM
Meinersbur requested review of this revision.Oct 13 2020, 11:58 PM
Meinersbur updated this revision to Diff 303615.EditedNov 6 2020, 9:00 PM

Rebase and add REQUIRES: shell to additional tests

DavidTruby resigned from this revision.Jan 20 2021, 12:27 PM

ping

Is there interest in this? Windows buildbot is still failing (http://meinersbur.de:8011/#/builders/146/builds/169).

awarzynski accepted this revision.Jun 2 2021, 1:47 AM

Makes a lot of sense, thanks!

This revision is now accepted and ready to land.Jun 2 2021, 1:47 AM

@Meinersbur In the longer term, to enable these tests on winodws, would porting the shell scripts to python be the right approach?

A lot has changed since I put up this patch and I will need some time rebasing.

@Meinersbur In the longer term, to enable these tests on winodws, would porting the shell scripts to python be the right approach?

LLVM (especially llvm-lit) also uses python for testing, so I think it makes a lot of sense. I think it was discussed once in a flang call.