This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo][Docs] Document MIR language debug-info constructs
ClosedPublic

Authored by jmorse on Oct 13 2020, 11:28 AM.

Details

Summary

In D85741 Adrian suggested the experimental instruction referencing meta-instruction should be documented; further analysis shows that actually we don't document any debug info features of MIR. This patch adds explanations for debug-location, DBG_VALUE and other things, plus DBG_INSTR_REF.

Rather than trying to describe what these things mean, I've linked to source level debugging; IMO better to document the syntax in the MIR language reference, and the meaning elsewhere.

Diff Detail

Event Timeline

jmorse created this revision.Oct 13 2020, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2020, 11:28 AM
jmorse requested review of this revision.Oct 13 2020, 11:28 AM

Thanks!

llvm/docs/MIRLangRef.rst
797

debug information is a more common term I think

801

Can you unify all headlines to use the same capitalization rules?

816

typo: Fixed Variable Locations

842

vari*a*ble

MaskRay added inline comments.
llvm/docs/MIRLangRef.rst
797

Both GCC documentation and DWARF specifications refer to this term as "debugging information". There are many places using "debug information" as well. I think perhaps "debugging information" is indeed more formal and using it here may be fine.

djtodoro added inline comments.
llvm/docs/MIRLangRef.rst
894

I recommend adding references (SEE ALSO) to the how-to-update-debug-info and source-level-debugging pages.

jmorse updated this revision to Diff 299936.Oct 22 2020, 5:31 AM

(Revise to address comments)

jmorse marked 4 inline comments as done.Oct 22 2020, 5:32 AM
jmorse added inline comments.
llvm/docs/MIRLangRef.rst
797

I've no strong opinion on the wording; alright to leave it as it is?

801

Have rewritten "locations" to be lower case

djtodoro accepted this revision.Nov 3 2020, 1:51 AM
This revision is now accepted and ready to land.Nov 3 2020, 1:51 AM
This revision was automatically updated to reflect the committed changes.
jmorse marked an inline comment as done.