Page MenuHomePhabricator

[AMDGPU] Add MC layer support for v_fmac_legacy_f32
ClosedPublic

Authored by foad on Mon, Oct 12, 8:56 AM.

Details

Summary

This instruction was introduced in GFX10.3, reusing the opcode of
v_mac_legacy_f32 from GFX10.1.

Diff Detail

Event Timeline

foad created this revision.Mon, Oct 12, 8:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Oct 12, 8:56 AM
foad requested review of this revision.Mon, Oct 12, 8:56 AM
arsenm added inline comments.Mon, Oct 12, 9:27 AM
llvm/test/MC/AMDGPU/gfx1030_unsupported.s
2

The sutarget features are broken and should be all lowercase

It also seems to lack changes in SIFoldOperands, SIInstrInfo::FoldImmediate, SIInstrInfo::convertToThreeAddress, SIInstrInfo::canShrink. I think these can go in a separate change.

foad added a comment.Tue, Oct 13, 1:05 AM

It also seems to lack changes in SIFoldOperands, SIInstrInfo::FoldImmediate, SIInstrInfo::convertToThreeAddress, SIInstrInfo::canShrink. I think these can go in a separate change.

Right. I'll change the summary to make it clear that this just adds asm/dis support.

llvm/test/MC/AMDGPU/gfx1030_unsupported.s
2

Do you mean they're broken in some other way, as well as not being lowercase?

rampitec added inline comments.Tue, Oct 13, 1:13 AM
llvm/test/MC/AMDGPU/gfx1030_unsupported.s
2

Shall be enough just to change the case. Subpar, but on par with the rest of the tests.

foad updated this revision to Diff 297804.Tue, Oct 13, 2:56 AM

Lowercase subtarget feature names.

foad retitled this revision from [AMDGPU] Add v_fmac_legacy_f32 to [AMDGPU] Add MC layer support for v_fmac_legacy_f32.Tue, Oct 13, 5:41 AM
This revision is now accepted and ready to land.Tue, Oct 13, 8:20 AM
This revision was landed with ongoing or failed builds.Tue, Oct 13, 2:07 PM
This revision was automatically updated to reflect the committed changes.