Page MenuHomePhabricator

[flang][NFC] Fix mis-matched struct/class declarations
ClosedPublic

Authored by tskeith on Oct 1 2020, 4:51 PM.

Details

Summary

The template ListDirectedStatementState was declared as a struct and then as a class.
Fix it so they match.

Diff Detail

Event Timeline

tskeith created this revision.Oct 1 2020, 4:51 PM
Herald added a project: Restricted Project. · View Herald Transcript
tskeith requested review of this revision.Oct 1 2020, 4:51 PM
tskeith retitled this revision from [flang] Fix mis-matched struct/class declarations to [flang][NFC] Fix mis-matched struct/class declarations.Oct 1 2020, 4:53 PM
tskeith edited the summary of this revision. (Show Details)

The other specialization of this template is a class, though, so maybe the best fix is to change the earlier template struct to a class so that they all are so. I've got a fix on the way that does that, I think.

The other specialization of this template is a class, though, so maybe the best fix is to change the earlier template struct to a class so that they all are so. I've got a fix on the way that does that, I think.

The only other specialization I see is immediately above and it's a struct.

klausler accepted this revision.Oct 2 2020, 8:58 AM

The other specialization of this template is a class, though, so maybe the best fix is to change the earlier template struct to a class so that they all are so. I've got a fix on the way that does that, I think.

The only other specialization I see is immediately above and it's a struct.

Ok. When I'm all done, it'll be a class, but I'll make sure to keep things consistent.

This revision is now accepted and ready to land.Oct 2 2020, 8:58 AM
tskeith updated this revision to Diff 295898.Oct 2 2020, 1:08 PM

Make them all class rather than struct.

This revision was landed with ongoing or failed builds.Oct 2 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.