This is an archive of the discontinued LLVM Phabricator instance.

Differential D88456

[COFF][CG Profile] set undefined symbol to external
ClosedPublic

Authored by zequanwu on Sep 28 2020, 5:17 PM.

Details

Reviewers
rnk
aeubanks
Commits
rGa9abe1f7859e: [COFF][CG Profile] set undefined symbol to external

Diff Detail

Event Timeline

zequanwu created this revision.Sep 28 2020, 5:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2020, 5:17 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
zequanwu requested review of this revision.Sep 28 2020, 5:17 PM
zequanwu mentioned this in D87811: [CodeGen] emit CG profile for COFF object file.Sep 28 2020, 5:19 PM
Harbormaster completed remote builds in B73249: Diff 294838.Sep 28 2020, 5:29 PM
zequanwu added a reviewer: aeubanks.Sep 28 2020, 6:46 PM
rnk accepted this revision.Sep 29 2020, 9:37 AM

lgtm

I wasn't able to construct an example on Linux where the call graph reference needs to be weak. We'll have to keep an eye out for it though.

This revision is now accepted and ready to land.Sep 29 2020, 9:37 AM
Closed by commit rGa9abe1f7859e: [COFF][CG Profile] set undefined symbol to external (authored by zequanwu). · Explain WhySep 29 2020, 9:50 AM
This revision was automatically updated to reflect the committed changes.
zequanwu added a commit: rGa9abe1f7859e: [COFF][CG Profile] set undefined symbol to external.

Revision Contents

PathSize
llvm/
lib/
MC/
4 lines
test/
MC/
COFF/
28 lines

Diff 295022

llvm/lib/MC/MCWinCOFFStreamer.cpp

Show First 20 Lines • Show All 334 Lines • ▼ Show 20 Linesvoid MCWinCOFFStreamer::emitCGProfileEntry(const MCSymbolRefExpr *From,
if (!From->getSymbol().isTemporary() && !To->getSymbol().isTemporary()) if (!From->getSymbol().isTemporary() && !To->getSymbol().isTemporary())
getAssembler().CGProfile.push_back({From, To, Count}); getAssembler().CGProfile.push_back({From, To, Count});
} }
void MCWinCOFFStreamer::finalizeCGProfileEntry(const MCSymbolRefExpr *&SRE) { void MCWinCOFFStreamer::finalizeCGProfileEntry(const MCSymbolRefExpr *&SRE) {
const MCSymbol *S = &SRE->getSymbol(); const MCSymbol *S = &SRE->getSymbol();
bool Created; bool Created;
getAssembler().registerSymbol(*S, &Created); getAssembler().registerSymbol(*S, &Created);
if (Created) { if (Created)
cast<MCSymbolCOFF>(S)->setIsWeakExternal();
cast<MCSymbolCOFF>(S)->setExternal(true); cast<MCSymbolCOFF>(S)->setExternal(true);
} }
}
void MCWinCOFFStreamer::finalizeCGProfile() { void MCWinCOFFStreamer::finalizeCGProfile() {
for (MCAssembler::CGProfileEntry &E : getAssembler().CGProfile) { for (MCAssembler::CGProfileEntry &E : getAssembler().CGProfile) {
finalizeCGProfileEntry(E.From); finalizeCGProfileEntry(E.From);
finalizeCGProfileEntry(E.To); finalizeCGProfileEntry(E.To);
} }
} }
Show All 9 Lines

llvm/test/MC/COFF/cgprofile.s

Show All 24 Lines
# CHECK-NEXT: RelocationCount: # CHECK-NEXT: RelocationCount:
# CHECK-NEXT: LineNumberCount: # CHECK-NEXT: LineNumberCount:
# CHECK-NEXT: Characteristics [ (0x100800) # CHECK-NEXT: Characteristics [ (0x100800)
# CHECK-NEXT: IMAGE_SCN_ALIGN_1BYTES (0x100000) # CHECK-NEXT: IMAGE_SCN_ALIGN_1BYTES (0x100000)
# CHECK-NEXT: IMAGE_SCN_LNK_REMOVE (0x800) # CHECK-NEXT: IMAGE_SCN_LNK_REMOVE (0x800)
# CHECK-NEXT: ] # CHECK-NEXT: ]
# CHECK-NEXT: SectionData ( # CHECK-NEXT: SectionData (
# CHECK-NEXT: 0000: 0A000000 0E000000 20000000 00000000 # CHECK-NEXT: 0000: 0A000000 0E000000 20000000 00000000
# CHECK-NEXT: 0010: 11000000 0A000000 0B000000 00000000 # CHECK-NEXT: 0010: 0F000000 0A000000 0B000000 00000000
# CHECK-NEXT: 0020: 0B000000 0C000000 14000000 00000000 # CHECK-NEXT: 0020: 0B000000 0C000000 14000000 00000000
# CHECK-NEXT: ) # CHECK-NEXT: )
# CHECK: Symbols [ # CHECK: Symbols [
# CHECK: Name: a # CHECK: Name: a
# CHECK-NEXT: Value: # CHECK-NEXT: Value:
# CHECK-NEXT: Section: .test # CHECK-NEXT: Section: .test
# CHECK-NEXT: BaseType: # CHECK-NEXT: BaseType:
Show All 21 Lines
# CHECK-NEXT: ComplexType: # CHECK-NEXT: ComplexType:
# CHECK-NEXT: StorageClass: Static # CHECK-NEXT: StorageClass: Static
# CHECK-NEXT: AuxSymbolCount: # CHECK-NEXT: AuxSymbolCount:
# CHECK: Name: b # CHECK: Name: b
# CHECK-NEXT: Value: # CHECK-NEXT: Value:
# CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED # CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED
# CHECK-NEXT: BaseType: # CHECK-NEXT: BaseType:
# CHECK-NEXT: ComplexType: # CHECK-NEXT: ComplexType:
# CHECK-NEXT: StorageClass: WeakExternal
# CHECK-NEXT: AuxSymbolCount: 1
# CHECK-NEXT: AuxWeakExternal {
# CHECK-NEXT: Linked: .weak.b.default.late
# CHECK-NEXT: Search: Alias
# CHECK-NEXT: }
# CHECK: Name: .weak.b.default.late
# CHECK-NEXT: Value:
# CHECK-NEXT: Section: IMAGE_SYM_ABSOLUTE
# CHECK-NEXT: BaseType:
# CHECK-NEXT: ComplexType:
# CHECK-NEXT: StorageClass: External # CHECK-NEXT: StorageClass: External
# CHECK-NEXT: AuxSymbolCount: 0 # CHECK-NEXT: AuxSymbolCount:
# CHECK: Name: freq # CHECK: Name: freq
# CHECK-NEXT: Value: # CHECK-NEXT: Value:
# CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED # CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED
# CHECK-NEXT: BaseType: # CHECK-NEXT: BaseType:
# CHECK-NEXT: ComplexType: # CHECK-NEXT: ComplexType:
# CHECK-NEXT: StorageClass: WeakExternal
# CHECK-NEXT: AuxSymbolCount: 1
# CHECK-NEXT: AuxWeakExternal {
# CHECK-NEXT: Linked: .weak.freq.default.late
# CHECK-NEXT: Search: Alias
# CHECK-NEXT: }
# CHECK: Name: .weak.freq.default.late
# CHECK-NEXT: Value:
# CHECK-NEXT: Section: IMAGE_SYM_ABSOLUTE
# CHECK-NEXT: BaseType:
# CHECK-NEXT: ComplexType:
# CHECK-NEXT: StorageClass: External # CHECK-NEXT: StorageClass: External
# CHECK-NEXT: AuxSymbolCount: 0 # CHECK-NEXT: AuxSymbolCount:
# CHECK: CGProfile [ # CHECK: CGProfile [
# CHECK-NEXT: CGProfileEntry { # CHECK-NEXT: CGProfileEntry {
# CHECK-NEXT: From: a # CHECK-NEXT: From: a
# CHECK-NEXT: To: b # CHECK-NEXT: To: b
# CHECK-NEXT: Weight: 32 # CHECK-NEXT: Weight: 32
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT: CGProfileEntry { # CHECK-NEXT: CGProfileEntry {
Show All 10 Lines