This is an archive of the discontinued LLVM Phabricator instance.

scudo: Re-order Allocator fields for improved performance. NFCI.
ClosedPublic

Authored by pcc on Sep 25 2020, 7:10 PM.

Details

Summary

Move smaller and frequently-accessed fields near the beginning
of the data structure in order to improve locality and reduce
the number of instructions required to form an access to those
fields. With this change I measured a ~5% performance improvement on
BM_malloc_sql_trace_default on aarch64 Android devices (Pixel 4 and
DragonBoard 845c).

Diff Detail

Event Timeline

pcc created this revision.Sep 25 2020, 7:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2020, 7:10 PM
Herald added subscribers: Restricted Project, kristof.beyls. · View Herald Transcript
pcc requested review of this revision.Sep 25 2020, 7:10 PM
cryptoad accepted this revision.Sep 28 2020, 9:03 AM

Thanks Peter!

This revision is now accepted and ready to land.Sep 28 2020, 9:03 AM
eugenis accepted this revision.Sep 28 2020, 10:44 AM
eugenis added a subscriber: eugenis.

Nice.