This is an archive of the discontinued LLVM Phabricator instance.

[mlir][SCFToGPU] LaunchOp propagate optional attributes
ClosedPublic

Authored by abialas on Sep 24 2020, 2:04 AM.

Details

Summary

Allow propagating optional user defined attributes during SCF to GPU conversion. Gives opportunity to use user defined attributes in the further lowering. For example setting subgroup size, or other options for GPU dispatch. This does not break backward compatibility and does not require new attributes, just allow passing optional ones.

Diff Detail

Event Timeline

abialas created this revision.Sep 24 2020, 2:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2020, 2:04 AM
abialas requested review of this revision.Sep 24 2020, 2:04 AM
ftynse accepted this revision.Sep 24 2020, 2:41 AM
This revision is now accepted and ready to land.Sep 24 2020, 2:41 AM

Consider adding a test.

abialas updated this revision to Diff 293997.Sep 24 2020, 3:12 AM

added simple test

This revision was automatically updated to reflect the committed changes.