Page MenuHomePhabricator
Differential D88149

[OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant
ClosedPublic
Actions

Authored by protze.joachim on Sep 23 2020, 6:03 AM.

Details

Reviewers
jdoerfert
AndreyChurbanov
ABataev
grokos
Commits
rG55cff5b28865: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant
Summary

OpenMP 5.1 defines omp_get_initial_device to return the same value as omp_get_num_devices.

Since this change is also 5.0 compliant, no versioning is needed.

Diff Detail

Event Timeline

protze.joachim created this revision.Sep 23 2020, 6:03 AM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptSep 23 2020, 6:03 AM
protze.joachim requested review of this revision.Sep 23 2020, 6:03 AM
Herald added a subscriber: sstefan1. · View Herald TranscriptSep 23 2020, 6:03 AM
protze.joachim updated this revision to Diff 293711.Sep 23 2020, 6:06 AM

Removed accidently added printf from a test.

grokos added a subscriber: grokos.Sep 23 2020, 6:18 AM
grokos added inline comments.
openmp/runtime/src/kmp.h
3879

So we can also remove the HOST_DEVICE macro from openmp/libomptarget/include/omptarget.h:24.

Harbormaster completed remote builds in B72651: Diff 293708.Sep 23 2020, 6:32 AM
RaviNarayanaswamy added a subscriber: RaviNarayanaswamy.Sep 23 2020, 4:00 PM

Can you also remove the definition in the header file include/omptarget.h

#define HOST_DEVICE -10

protze.joachim updated this revision to Diff 294014.Sep 24 2020, 4:31 AM

Removed HOST_DEVICE definition from the header as suggested in the reviews.

jdoerfert accepted this revision.Sep 25 2020, 9:25 AM

LGTM, one nit. Give @grokos and @RaviNarayanaswamy some time to comment or accept as well.

openmp/runtime/src/kmp_ftn_entry.h
969–970

Nit: Please put the comments in the line before, also below.

This revision is now accepted and ready to land.Sep 25 2020, 9:25 AM
RaviNarayanaswamy added a comment.Sep 25 2020, 2:41 PM

LGTM

grokos accepted this revision.Sep 25 2020, 2:53 PM

LGTM as well.

Closed by commit rG55cff5b28865: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant (authored by protze.joachim). · Explain WhySep 30 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.
protze.joachim added a commit: rG55cff5b28865: [OpenMP][libomptarget] make omp_get_initial_device 5.1 compliant.
protze.joachim mentioned this in rG71041a8b6bc4: [OpenMP][libomptarget][Tests] fix failing test.Nov 3 2020, 4:33 AM

Revision Contents
Changeset List

PathSize
openmp/
libomptarget/
include/
1 line
src/
5 lines
runtime/
src/
1 line
10 lines

Diff 295429

View Options

openmp/libomptarget/include/omptarget.h

Loading...
View Options

openmp/libomptarget/src/api.cpp

Loading...
View Options

openmp/runtime/src/kmp.h

Loading...
View Options

openmp/runtime/src/kmp_ftn_entry.h

Loading...