Page MenuHomePhabricator
Differential D88068

[CMake] Use append for CMAKE_REQUIRED_* variables
ClosedPublic
Actions

Authored by phosek on Sep 21 2020, 10:32 PM.

Details

Reviewers
smeenai
leonardchan
Commits
rGbc3615f50e58: [CMake] Use append for CMAKE_REQUIRED_* variables
Summary

This ensures that required includes and libraries such as -lm that
were added earlier aren't overwritten.

Diff Detail

Event Timeline

phosek created this revision.Sep 21 2020, 10:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2020, 10:32 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
phosek requested review of this revision.Sep 21 2020, 10:32 PM
smeenai accepted this revision.Sep 21 2020, 11:00 PM

LGTM

This revision is now accepted and ready to land.Sep 21 2020, 11:00 PM
Harbormaster completed remote builds in B72472: Diff 293340.Sep 21 2020, 11:05 PM
Closed by commit rGbc3615f50e58: [CMake] Use append for CMAKE_REQUIRED_* variables (authored by phosek). · Explain WhySep 21 2020, 11:40 PM
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rGbc3615f50e58: [CMake] Use append for CMAKE_REQUIRED_* variables.

Revision Contents
Changeset List

PathSize
llvm/
cmake/
8 lines

Diff 293353

View Options

llvm/cmake/config-ix.cmake

Loading...