Page MenuHomePhabricator

[libcxx] Add targets to available features.
Needs ReviewPublic

Authored by danielkiss on Mon, Sep 21, 8:43 AM.

Details

Reviewers
jgorbe
lhames
ldionne
Group Reviewers
Restricted Project
Restricted Project
Restricted Project
Summary

This patch add the target-* (x86_64-*) as used elsewhere in llvm.

Diff Detail

Event Timeline

danielkiss created this revision.Mon, Sep 21, 8:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Sep 21, 8:43 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
danielkiss requested review of this revision.Mon, Sep 21, 8:43 AM

some test never runs due to these features are missing. I realised this when tried to run this one: https://github.com/llvm/llvm-project/blob/master/libunwind/test/remember_state_leak.pass.sh.s#L1

ldionne requested changes to this revision.Thu, Oct 1, 5:40 AM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/utils/libcxx/test/config.py
269–283

None of these features are used anywhere in the tests as far as I can find. Why add them?

288

Not used in the tests, I would prefer we don't add features just for the sake of having them.

291–303

I think it only makes sense to add those, and the reason is that Lit doesn't allow matching partial triples. We already add the full target triple as a Lit feature, and I think it would be nicer to be able to say something like // REQUIRES: x86_64-linux-* instead of having to add these features. But Lit doesn't do that, so let's add them.

This revision now requires changes to proceed.Thu, Oct 1, 5:40 AM
danielkiss retitled this revision from [libcxx] Add platforms and targets to available features. to [libcxx] Add targets to available features..
danielkiss edited the summary of this revision. (Show Details)
danielkiss marked 3 inline comments as done.Mon, Oct 12, 4:03 AM

The system-* and native are used in clang and lldb only, so dropped.
I only added them for consistency across llvm components.