Page MenuHomePhabricator

[MemLoc] Support bcmp in MemoryLocation::getForArgument
ClosedPublic

Authored by xbolva00 on Sep 19 2020, 7:20 AM.

Diff Detail

Event Timeline

xbolva00 created this revision.Sep 19 2020, 7:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2020, 7:20 AM
xbolva00 requested review of this revision.Sep 19 2020, 7:20 AM
xbolva00 updated this revision to Diff 292959.Sep 19 2020, 7:23 AM

Fixed test name.

fhahn added a comment.Sep 19 2020, 7:33 AM

Could you also add a test for BasicAA, in llvm/test/Analysis/BasicAA/libfuncs.ll?

xbolva00 updated this revision to Diff 292961.Sep 19 2020, 7:56 AM

Added testcase

Could you also add a test for BasicAA, in llvm/test/Analysis/BasicAA/libfuncs.ll?

Sure! I had to change test case "setup" (we need the gnu triple to recognize bcmp).

xbolva00 updated this revision to Diff 292962.Sep 19 2020, 7:58 AM
fhahn accepted this revision.Sep 19 2020, 8:07 AM

LGTM, thanks!

llvm/test/Analysis/BasicAA/libfuncs.ll
89

nit: trailing empty line.

llvm/test/Transforms/DeadStoreElimination/MSSA/libcalls.ll
134

nit: just 1 empty line?

This revision is now accepted and ready to land.Sep 19 2020, 8:07 AM
This revision was automatically updated to reflect the committed changes.