Page MenuHomePhabricator

[MemorySSA] Rename uses in blocks with Phis.
ClosedPublic

Authored by asbirlea on Sep 14 2020, 6:18 PM.

Details

Summary

Renaming should include blocks with existing Phis.

Resolves PR45927.

Diff Detail

Event Timeline

asbirlea created this revision.Sep 14 2020, 6:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2020, 6:18 PM
asbirlea requested review of this revision.Sep 14 2020, 6:18 PM

but when prinitng we were still seeing an unoptimized access
as MustAlias due to the flag not being reset

oof. maybe we should make the accessor for the AliasResult do return isOptimized() ? actualResult : MayAlias;?

lgtm either way though -- thanks for this!

This revision is now accepted and ready to land.Sep 15 2020, 5:27 PM
asbirlea updated this revision to Diff 292123.Sep 16 2020, 12:13 AM

Updated the printing in separate revision. Rebase.

asbirlea edited the summary of this revision. (Show Details)Sep 16 2020, 12:13 AM
asbirlea updated this revision to Diff 292379.Sep 16 2020, 5:21 PM

Update to different approach.

asbirlea retitled this revision from [MemorySSA] Rename uses starting at defining access to [MemorySSA] Rename uses in blocks with Phis..Sep 16 2020, 5:22 PM
asbirlea edited the summary of this revision. (Show Details)

Incorrect previous approach. The renaming needs to start at the block with the new def, but it needs to rename all blocks in the IDF, not just those with phis added.

This revision was landed with ongoing or failed builds.Sep 16 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.