This is an archive of the discontinued LLVM Phabricator instance.

[NFC][Asan] Don't use MetaData for size
ClosedPublic

Authored by vitalybuka on Sep 14 2020, 3:42 PM.

Details

Summary

Now we have enough space in the ChunkHeader.
45 bit is enough for kMaxAllowedMallocSize.

Depends on D87642.

Diff Detail

Event Timeline

vitalybuka created this revision.Sep 14 2020, 3:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2020, 3:42 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka requested review of this revision.Sep 14 2020, 3:42 PM
vitalybuka edited the summary of this revision. (Show Details)Sep 14 2020, 3:53 PM
morehouse accepted this revision.Sep 14 2020, 4:47 PM
morehouse added inline comments.
compiler-rt/lib/asan/asan_allocator.cpp
103

This increases the header size by 2 bytes, but we should be OK since we trimmed 2 bytes previously, right?

567

Can we use meta[0] instead now?

This revision is now accepted and ready to land.Sep 14 2020, 4:47 PM
vitalybuka added inline comments.Sep 14 2020, 11:53 PM
compiler-rt/lib/asan/asan_allocator.cpp
103

yes.

567

yes, but it's going away in followup patches

This revision was automatically updated to reflect the committed changes.