This is an archive of the discontinued LLVM Phabricator instance.

Fix typo
ClosedPublic

Authored by YangZhihui on Sep 9 2020, 1:46 AM.

Diff Detail

Event Timeline

YangZhihui created this revision.Sep 9 2020, 1:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2020, 1:46 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
YangZhihui requested review of this revision.Sep 9 2020, 1:46 AM

I don't have commit access.
Please help me commit it.
Thanks : )

MyDeveloperDay accepted this revision.Sep 9 2020, 7:00 AM

LGTM, thank you for doing this..

This revision is now accepted and ready to land.Sep 9 2020, 7:00 AM

LGTM, thank you for doing this..

Thanks,
may me you can help me commit it : )

MyDeveloperDay requested changes to this revision.Sep 15 2020, 1:03 AM

I have realized this is the wrong change

The actual error is in Format.h

clang/docs/ClangFormatStyleOption.rst is generated using the clang/docs/tools/dump_format_style.py if we commit this change in the rst will get reintroduced when that is run

If you are still interested please change Format.h

/// Break parameters list into lines when there is nested block
 /// parameters in a fuction call.
 /// \code
 ///   false:
 ///    - (void)_aMethod
 ///    {
 ///        [self.test1 t:self w:self callback:^(typeof(self) self, NSNumber
 ///        *u, NSNumber *v) {
 ///            u = c;
 ///        }]
 ///    }
This revision now requires changes to proceed.Sep 15 2020, 1:03 AM
YangZhihui retitled this revision from Fix typo in doc ClangFormatStyleOptions.rst to Fix typo in Format.h.

I have realized this is the wrong change

The actual error is in Format.h

clang/docs/ClangFormatStyleOption.rst is generated using the clang/docs/tools/dump_format_style.py if we commit this change in the rst will get reintroduced when that is run

If you are still interested please change Format.h

/// Break parameters list into lines when there is nested block
 /// parameters in a fuction call.
 /// \code
 ///   false:
 ///    - (void)_aMethod
 ///    {
 ///        [self.test1 t:self w:self callback:^(typeof(self) self, NSNumber
 ///        *u, NSNumber *v) {
 ///            u = c;
 ///        }]
 ///    }

Thanks for tell me this error
I'll change Format.h

MyDeveloperDay added a comment.EditedSep 15 2020, 4:25 AM

Ok almost...

so you change the Format.h, then run the docs/tools/clang_format_style.py and attach both the rst and the .h to the review

MyDeveloperDay requested changes to this revision.Sep 15 2020, 7:47 AM
This revision now requires changes to proceed.Sep 15 2020, 7:47 AM
YangZhihui retitled this revision from Fix typo in Format.h to Fix typo.
MyDeveloperDay added inline comments.
clang/docs/ClangFormatStyleOptions.rst
778

So this is an example of where someone has changed the .rst and not the Format.h! @arichardson

I recommend keeping Format.h and rst in lock step.

MyDeveloperDay accepted this revision.Sep 16 2020, 5:34 AM
This revision is now accepted and ready to land.Sep 16 2020, 5:34 AM
arichardson added inline comments.Sep 16 2020, 6:45 AM
clang/docs/ClangFormatStyleOptions.rst
778

Ah I was not aware of that script, I just did both manually but must have adjusted one later. Sorry!