This is an archive of the discontinued LLVM Phabricator instance.

Differential D87255

[PATCH 24/27] [noalias] DeadArgumentElimination
Needs ReviewPublic

Authored by jeroen.dobbelaere on Sep 7 2020, 2:35 PM.

Details

Reviewers
hfinkel
jdoerfert
Summary

DeadArgumentElimination: keep track of !noalias (for Full Restrict) and !alias.scope information for calls that are modified.

Diff Detail

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
8 lines
test/
Transforms/
DeadArgElim/
25 lines

Diff 346137

llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp

Show First 20 Lines • Show All 201 Lines • ▼ Show 20 Lines if (InvokeInst *II = dyn_cast<InvokeInst>(CB)) {
Args, OpBundles, "", CB); Args, OpBundles, "", CB);
} else { } else {
NewCB = CallInst::Create(NF, Args, OpBundles, "", CB); NewCB = CallInst::Create(NF, Args, OpBundles, "", CB);
cast<CallInst>(NewCB)->setTailCallKind( cast<CallInst>(NewCB)->setTailCallKind(
cast<CallInst>(CB)->getTailCallKind()); cast<CallInst>(CB)->getTailCallKind());
} }
NewCB->setCallingConv(CB->getCallingConv()); NewCB->setCallingConv(CB->getCallingConv());
NewCB->setAttributes(PAL); NewCB->setAttributes(PAL);
NewCB->copyMetadata(*CB, {LLVMContext::MD_prof, LLVMContext::MD_dbg}); NewCB->copyMetadata(*CB,
{LLVMContext::MD_prof, LLVMContext::MD_dbg,
LLVMContext::MD_noalias, LLVMContext::MD_alias_scope});
Args.clear(); Args.clear();
if (!CB->use_empty()) if (!CB->use_empty())
CB->replaceAllUsesWith(NewCB); CB->replaceAllUsesWith(NewCB);
NewCB->takeName(CB); NewCB->takeName(CB);
▲ Show 20 Lines • Show All 725 Lines • ▼ Show 20 Lines if (InvokeInst *II = dyn_cast<InvokeInst>(&CB)) {
Args, OpBundles, "", CB.getParent()); Args, OpBundles, "", CB.getParent());
} else { } else {
NewCB = CallInst::Create(NFTy, NF, Args, OpBundles, "", &CB); NewCB = CallInst::Create(NFTy, NF, Args, OpBundles, "", &CB);
cast<CallInst>(NewCB)->setTailCallKind( cast<CallInst>(NewCB)->setTailCallKind(
cast<CallInst>(&CB)->getTailCallKind()); cast<CallInst>(&CB)->getTailCallKind());
} }
NewCB->setCallingConv(CB.getCallingConv()); NewCB->setCallingConv(CB.getCallingConv());
NewCB->setAttributes(NewCallPAL); NewCB->setAttributes(NewCallPAL);
NewCB->copyMetadata(CB, {LLVMContext::MD_prof, LLVMContext::MD_dbg}); NewCB->copyMetadata(CB,
{LLVMContext::MD_prof, LLVMContext::MD_dbg,
LLVMContext::MD_noalias, LLVMContext::MD_alias_scope});
Args.clear(); Args.clear();
ArgAttrVec.clear(); ArgAttrVec.clear();
if (!CB.use_empty() || CB.isUsedByMetadata()) { if (!CB.use_empty() || CB.isUsedByMetadata()) {
if (NewCB->getType() == CB.getType()) { if (NewCB->getType() == CB.getType()) {
// Return type not changed? Just replace users then. // Return type not changed? Just replace users then.
CB.replaceAllUsesWith(NewCB); CB.replaceAllUsesWith(NewCB);
NewCB->takeName(&CB); NewCB->takeName(&CB);
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines

llvm/test/Transforms/DeadArgElim/noalias.ll

  • This file was added.
; RUN: opt -deadargelim -S < %s | FileCheck %s
; Checks if !noalias metadata is corret in deadargelim.
define void @caller() #0 {
; CHECK: call void @test_vararg(), !noalias ![[NA:[0-9]]]
; CHECK: call void @test(), !noalias ![[NA]]
call void (i32, ...) @test_vararg(i32 1), !noalias !0
call void @test(i32 1), !noalias !0
ret void
}
define internal void @test_vararg(i32, ...) #1 {
ret void
}
define internal void @test(i32 %a) #1 {
ret void
}
; CHECK:![[NA]] = !{![[NA2:[0-9]]]}
; CHECK:![[NA2]] = distinct !{![[NA2]], !"the var"}
!0 = !{!1}
!1 = distinct !{!1, !"the var"}