This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readelf/obj] - Use `RelSymbol<ELFT>` instead of std::pair. NFCI.
ClosedPublic

Authored by grimar on Sep 3 2020, 7:52 AM.

Details

Summary

We have the RelSymbol<ELFT> struct and can use it instead
of std::pair<const Elf_Sym *, std::string> in a few methods.

This is a bit cleaner, but also should allow to get rid of
printDynamicRelocation methods for both styles after landing D87089.

Diff Detail

Event Timeline

grimar created this revision.Sep 3 2020, 7:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2020, 7:52 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
grimar requested review of this revision.Sep 3 2020, 7:52 AM
jhenderson accepted this revision.Sep 4 2020, 12:52 AM

LGTM, with suggestion.

llvm/tools/llvm-readobj/ELFDumper.cpp
118–119
This revision is now accepted and ready to land.Sep 4 2020, 12:52 AM