Page MenuHomePhabricator

[mlir] Support default valued attribute in StructsGen
ClosedPublic

Authored by antiagainst on Sep 2 2020, 2:34 PM.

Details

Summary

Its handling is similar to optional attributes, except for the
getter method.

Diff Detail

Event Timeline

antiagainst created this revision.Sep 2 2020, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2020, 2:34 PM
antiagainst requested review of this revision.Sep 2 2020, 2:34 PM
rsuderman accepted this revision.Sep 2 2020, 9:33 PM

Looks good to me. One nit: it may be worth reordering the includes into the test to remove that pesky pre-merge check error.

This revision is now accepted and ready to land.Sep 2 2020, 9:33 PM

Looks good to me. One nit: it may be worth reordering the includes into the test to remove that pesky pre-merge check error.

The warning is a bit strange to me. The include files are already sorted.. So I'll just ignore it.

This revision was landed with ongoing or failed builds.Sep 3 2020, 6:50 AM
This revision was automatically updated to reflect the committed changes.