This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Affine] Support affine vector loads/stores in LICM
ClosedPublic

Authored by dcaballe on Sep 1 2020, 3:58 PM.

Details

Summary

Introduce affine memory op interfaces in AffineLoopInvariantCodeMotion so
that it can also work on affine.vector_load and affine.vector_store ops.

Diff Detail

Event Timeline

dcaballe created this revision.Sep 1 2020, 3:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2020, 3:58 PM
dcaballe requested review of this revision.Sep 1 2020, 3:58 PM
bondhugula accepted this revision.Sep 1 2020, 7:28 PM

Looks good.

This revision is now accepted and ready to land.Sep 1 2020, 7:28 PM

I'd reword the commit summary a bit to replace "Introduce" - instead, something like "Make use of ..."

I'd reword the commit summary a bit to replace "Introduce" - instead, something like "Make use of ..."

Will do. Thanks!

This revision was automatically updated to reflect the committed changes.