Page MenuHomePhabricator

[llvm-readobj/elf] - Improve warning messages, reported for .stack_sizes sections.

Authored by grimar on Tue, Sep 1, 6:11 AM.



Instead of referring to stack sizes sections only by name, we can add
section indexes and types to warnings reported.

Diff Detail

Event Timeline

grimar created this revision.Tue, Sep 1, 6:11 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Tue, Sep 1, 6:11 AM
MaskRay accepted this revision.Tue, Sep 1, 12:00 PM

.stack_sizes -> SHT_PROGBITS looks like information loss for me..... but the section index is an addition, and is potentially useful because an object file can have many .stack_sizes of the same name.

This revision is now accepted and ready to land.Tue, Sep 1, 12:00 PM
jhenderson accepted this revision.Wed, Sep 2, 1:16 AM

(Mutters something incoherent about .stack_sizes being identified by name not type)

I think the error message changes are fine, since they a) now include enough information to identify the section and b) it's obvious from the rest of the message that it's a stack sizes section that is being referred to. LGTM.